Discussion:
[Matplotlib-users] @image_comparison decorator and unittests
Fabien
2015-07-30 13:27:38 UTC
Permalink
Hi all,

is it possible to use the @image_comparison decorator for tests
generated within a unittest.TestCase class?

With my attempts so far the decorator was indeed instanicated at run
time but the test was not called, i.e. the test would allways pass...
Running the test with decorator from outside the class works fine.

Any idea? Thanks,

Fabien


------------------------------------------------------------------------------
Thomas Caswell
2015-07-30 13:42:16 UTC
Permalink
Paul Hobson expressed interest in making it easier to use the image
comparison tests out side of the mpl test suite

Tom
Post by Fabien
Hi all,
generated within a unittest.TestCase class?
With my attempts so far the decorator was indeed instanicated at run
time but the test was not called, i.e. the test would allways pass...
Running the test with decorator from outside the class works fine.
Any idea? Thanks,
Fabien
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
Jens Nielsen
2015-07-30 13:47:02 UTC
Permalink
Thomas Robitailles pytest image comparison plugin might also be of
interest
https://github.com/astrofrog/pytest-mpl

Jens
Post by Thomas Caswell
Paul Hobson expressed interest in making it easier to use the image
comparison tests out side of the mpl test suite
Tom
Post by Fabien
Hi all,
generated within a unittest.TestCase class?
With my attempts so far the decorator was indeed instanicated at run
time but the test was not called, i.e. the test would allways pass...
Running the test with decorator from outside the class works fine.
Any idea? Thanks,
Fabien
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
Paul Hobson
2015-07-30 14:29:32 UTC
Permalink
Fabien,

The @image_comparison operator is still somehwat of a black box for me. But
I can confirm your observation that it only works on top-level test
functions, not within a class.

It's on my long, and slowly shifting backlog of things to try to improve.
-paul
Post by Jens Nielsen
Thomas Robitailles pytest image comparison plugin might also be of
interest
https://github.com/astrofrog/pytest-mpl
Jens
Post by Thomas Caswell
Paul Hobson expressed interest in making it easier to use the image
comparison tests out side of the mpl test suite
Tom
Post by Fabien
Hi all,
generated within a unittest.TestCase class?
With my attempts so far the decorator was indeed instanicated at run
time but the test was not called, i.e. the test would allways pass...
Running the test with decorator from outside the class works fine.
Any idea? Thanks,
Fabien
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
Fabien
2015-07-30 14:39:35 UTC
Permalink
Thank you all for your replies. It's not an urgent problem:

1. Jens gave us a link to an existing third party lib, althought it's
not clear to me how it will work without pytest (i.e. with standard
unittest).

2. My workaround is simply to use top level test functions as you
suggest, and the rest works just fine.

It's already awesome enough to be able to test my plots in such an easy
way!!!

Thanks a lot,

Fabien
Post by Paul Hobson
Fabien,
But I can confirm your observation that it only works on top-level test
functions, not within a class.
It's on my long, and slowly shifting backlog of things to try to improve.
-paul
On Thu, Jul 30, 2015 at 6:47 AM, Jens Nielsen
Thomas Robitailles pytest image comparison plugin might also be of
interest
https://github.com/astrofrog/pytest-mpl
Jens
tor. 30. jul. 2015 kl. 14.43 skrev Thomas Caswell
Paul Hobson expressed interest in making it easier to use the
image comparison tests out side of the mpl test suite
Tom
On Thu, Jul 30, 2015, 9:28 AM Fabien
Hi all,
generated within a unittest.TestCase class?
With my attempts so far the decorator was indeed
instanicated at run
time but the test was not called, i.e. the test would
allways pass...
Running the test with decorator from outside the class works fine.
Any idea? Thanks,
Fabien
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
------------------------------------------------------------------------------
_______________________________________________
Matplotlib-users mailing list
https://lists.sourceforge.net/lists/listinfo/matplotlib-users
------------------------------------------------------------------------------
Loading...